lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 16 Aug 2022 13:03:24 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Denis Arefev <arefev@...mel.ru>
Cc:     Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org,
        trufanov@...mel.ru, vfh@...mel.ru
Subject: Re: [PATCH 3/3] i915-pmu: Add extra check NULL

On Tue, 16 Aug 2022, Denis Arefev <arefev@...mel.ru> wrote:
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

The subject prefix should be something along the lines of
"drm/i915/pmu".

The subject is misleading; there are no functional changes here, just
whitespace changes. I'm guessing you intended to send something else?

Finally, the commit message is primarily for describing why the change
is being made, not to advertize organizations or tools.


BR,
Jani.


>
> Signed-off-by: Denis Arefev <arefev@...mel.ru>
> ---
>  drivers/gpu/drm/i915/i915_pmu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
> index 34a7f0ef1f67..33db49ffac3d 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.c
> +++ b/drivers/gpu/drm/i915/i915_pmu.c
> @@ -704,8 +704,7 @@ static void i915_pmu_disable(struct perf_event *event)
>  		 * Decrement the reference count and clear the enabled
>  		 * bitmask when the last listener on an event goes away.
>  		 */
> -		if(engine != NULL)
> -		{
> +		if (engine != NULL) {
>  		        if (--engine->pmu.enable_count[sample] == 0)
>  			        engine->pmu.enable &= ~BIT(sample);
>  		}

-- 
Jani Nikula, Intel Open Source Graphics Center

Powered by blists - more mailing lists