[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <488ccf2a-5058-d3c6-43ad-8ec2b541fb86@linaro.org>
Date: Tue, 16 Aug 2022 13:13:20 +0300
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: cy_huang <u0084500@...il.com>, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, sre@...nel.org
Cc: alina_yu@...htek.com, cy_huang@...htek.com, alinayu829@...il.com,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: Add Richtek RT9471
battery charger
On 15/08/2022 10:34, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@...htek.com>
>
> Add bindings for the Richtek RT9471 I2C controlled battery charger.
>
> Co-developed-by: Alina Yu <alina_yu@...htek.com>
> Signed-off-by: Alina Yu <alina_yu@...htek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> ---
> Since v2
> - Remove the properties for interrupt controller things in the binding documentation.
> - Fix dtc error for typo, it's 'regulator-name', not 'regulator-compatible'.
> - Add regulator min/max microamp to allow otg vbus current adjustable in example.
> - Specify the active-level for charge-enable-gpios in binding example.
>
> ---
> .../bindings/power/supply/richtek,rt9471.yaml | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml
> new file mode 100644
> index 00000000..9286b82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/richtek,rt9471.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Richtek RT9471 3A Single Cell Switching Battery charger
> +
> +maintainers:
> + - Alina Yu <alina_yu@...htek.com>
> + - ChiYuan Huang <cy_huang@...htek.com>
> +
> +description: |
> + RT9471 is a switch-mode single cell Li-Ion/Li-Polymer battery charger for
> + portable applications. It supports USB BC1.2 port detection, current and
> + voltage regulations in both charging and boost mode.
> +
> + Datasheet is available at
> + https://www.richtek.com/assets/product_file/RT9471=RT9471D/DS9471D-02.pdf
> +
> +properties:
> + compatible:
> + const: richtek,rt9471
> +
> + reg:
> + maxItems: 1
> +
> + charge-enable-gpios:
> + description: GPIO used to turn on and off charging.
> + maxItems: 1
> +
> + wakeup-source: true
> +
> + interrupts:
> + maxItems: 1
> +
> + usb-otg-vbus-regulator:
> + type: object
> + unevaluatedProperties: false
> + $ref: /schemas/regulator/regulator.yaml#
ref goes before unevaluatedProperties (so one line up)
with above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists