linux-kernel - Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 16 Aug 2022 15:57:02 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "zhiyong.tao" <zhiyong.tao@...iatek.com>
Cc:     lee.jones@...aro.org, robh+dt@...nel.org, matthias.bgg@...il.com,
        lgirdwood@...il.com, broonie@...nel.org, eddie.huang@...iatek.com,
        a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        fshao@...omium.org, sen.chu@...iatek.com, hui.liu@...iatek.com,
        allen-kh.cheng@...iatek.com, hsin-hsiung.wang@...iatek.com,
        sean.wang@...iatek.com, macpaul.lin@...iatek.com,
        wen.su@...iatek.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366

On 16/08/2022 15:54, zhiyong.tao wrote:
> On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote:
>> On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@...iatek.com>
>> wrote:
>>>
>>> On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote:
>>>> On 12/08/2022 12:29, Zhiyong Tao wrote:
>>>>> Add mt6366 regulator document
>>>>>
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    const: mediatek,mt6366-regulator
>>>>> +
>>>>> +  regulators:
>>>>> +    type: object
>>>>> +    description: List of regulators and its properties
>>>>> +
>>>>> +    patternProperties:
>>>>> +      "^buck-
>>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$":
>>>>> +        type: object
>>>>> +        $ref: regulator.yaml#
>>>>> +        unevaluatedProperties: false
>>>>> +
>>>>> +      "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$":
>>>>> +        type: object
>>>>> +        $ref: regulator.yaml#
>>>>
>>>> You miss unevaluatedProperties in most of the places.
>>>
>>> Hi Krzysztof,
>>>    Thanks for your suggestion,
>>>    Do you mean that all places should have the
>>> unevaluatedProperties
>>> Properties ?
>>
>> Yes. You put it in some of the places which does not really make
>> sense...
> 
> Hi Krzysztof,
>    Thanks for your suggestion,
>    We find that if there is a properties "compatible = "regulator-
> fixed";" in ldo-vrf12, we should set unevaluatedProperties as true.
> or it will check yaml warning "Unevaluated Properties are not
> allowed('compatible' was unexpected)". is it right?
>    There is a properties "compatible = "regulator-fixed";"in ldo-vrf12.
> It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a
> required property". Can you help to give a suggestion to fix the
> warning? Add regulator-name for ldo-vrf12 or other suggestion?
> 

And how this regulator is supposed to work? Are you populating DT
children in your driver?

Best regards,
Krzysztof