linux-kernel - Re: [PATCH 1/2] usb: core: add a hook to check port init status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvuhcUx9R8Rdyfr4@rowland.harvard.edu>
Date:   Tue, 16 Aug 2022 09:53:53 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Ray Chi <raychi@...gle.com>
Cc:     gregkh@...uxfoundation.org, mathias.nyman@...el.com,
        badhri@...gle.com, albertccwang@...gle.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: core: add a hook to check port init status

On Tue, Aug 16, 2022 at 04:38:53PM +0800, Ray Chi wrote:
> This patch add a hook to check the port init status. Currently, only
> usbcore knows port init status even if the result is bad. It will cause
> a USB host keep doing USB enumeration for a long time when the USB host
> connects to a broken USB accessory.
> 
> The hc_driver could use the hook to know port init status and do possible
> error handling according to platform requirements or limitations.
> 
> Signed-off-by: Ray Chi <raychi@...gle.com>
> ---
>  drivers/usb/core/hub.c  | 14 ++++++++++++++
>  include/linux/usb/hcd.h |  8 ++++++++
>  2 files changed, 22 insertions(+)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 2633acde7ac1..6ce6092816cb 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c

> @@ -4855,6 +4865,10 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
>  					buf->bMaxPacketSize0;
>  			kfree(buf);
>  
> +			retval = hub_port_check_init_status(udev, r);
> +			if (retval < 0)
> +				goto fail;

For future reference, you should be aware that this code won't get 
executed if do_new_scheme is false.

Alan Stern