linux-kernel - Re: [PATCH] drivers/watchdog: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220816155059.GA3310237@roeck-us.net>
Date:   Tue, 16 Aug 2022 08:50:59 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jilin Yuan <yuanjilin@...rlc.com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/watchdog: fix repeated words in comments

On Tue, Aug 16, 2022 at 08:41:26PM +0800, Jilin Yuan wrote:
>  Delete the redundant word 'we'.
>  Delete the redundant word 'set'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>

I am going to ignore all those patches simply because the subject does
not mention the affected driver (but does mention the unnecessary
"drivers"). Really, and I have said that before, if you really have
to submit those cosmetic patches, at least do it right.

Guenter

> ---
>  drivers/watchdog/wdt_pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
> index d5e56b601351..a5fed7ea0243 100644
> --- a/drivers/watchdog/wdt_pci.c
> +++ b/drivers/watchdog/wdt_pci.c
> @@ -347,7 +347,7 @@ static irqreturn_t wdtpci_interrupt(int irq, void *dev_id)
>   *	@ppos: pointer to the position to write. No seeks allowed
>   *
>   *	A write to a watchdog device is defined as a keepalive signal. Any
> - *	write of data will do, as we we don't define content meaning.
> + *	write of data will do, as we don't define content meaning.
>   */
>  
>  static ssize_t wdtpci_write(struct file *file, const char __user *buf,
> @@ -443,7 +443,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,
>   *	open and on opening we load the counters. Counter zero is a 100Hz
>   *	cascade, into counter 1 which downcounts to reboot. When the counter
>   *	triggers counter 2 downcounts the length of the reset pulse which
> - *	set set to be as long as possible.
> + *	set to be as long as possible.
>   */
>  
>  static int wdtpci_open(struct inode *inode, struct file *file)
> -- 
> 2.36.1
>