linux-kernel - Re: [PATCH 2/2] drivers: iio: accel adxl312 and adxl314 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208170050.uOjv7usx-lkp@intel.com>
Date:   Wed, 17 Aug 2022 00:21:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     George Mois <george.mois@...log.com>, jic23@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        lucas.p.stankus@...il.com, George Mois <george.mois@...log.com>
Subject: Re: [PATCH 2/2] drivers: iio: accel adxl312 and adxl314 support

Hi George,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.0-rc1 next-20220816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/George-Mois/Add-support-for-ADXL312-and-ADXL314-accelerometers/20220816-190536
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: powerpc-randconfig-r026-20220815
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project aed5e3bea138ce581d682158eb61c27b3cfdd6ec)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/e8ba9a8642d5b9a0c37245f69439a007f9917c0a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review George-Mois/Add-support-for-ADXL312-and-ADXL314-accelerometers/20220816-190536
        git checkout e8ba9a8642d5b9a0c37245f69439a007f9917c0a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/iio/accel/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/iio/accel/adxl313_i2c.c:36:50: error: incompatible pointer types passing 'char[20]' to parameter of type 'const struct spi_device_id *' [-Werror,-Wincompatible-pointer-types]
           return adxl313_core_probe(&client->dev, regmap, client->name, NULL);
                                                           ^~~~~~~~~~~~
   drivers/iio/accel/adxl313.h:63:38: note: passing argument to parameter 'id' here
                          const struct spi_device_id *id,
                                                      ^
   1 error generated.
--
>> drivers/iio/accel/adxl313_spi.c:48:2: error: initializer element is not a compile-time constant
           adxl312_spi_regmap_config,
           ^~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +36 drivers/iio/accel/adxl313_i2c.c

636d4463303934 Lucas Stankus 2021-09-01  24  
636d4463303934 Lucas Stankus 2021-09-01  25  static int adxl313_i2c_probe(struct i2c_client *client)
636d4463303934 Lucas Stankus 2021-09-01  26  {
636d4463303934 Lucas Stankus 2021-09-01  27  	struct regmap *regmap;
636d4463303934 Lucas Stankus 2021-09-01  28  
636d4463303934 Lucas Stankus 2021-09-01  29  	regmap = devm_regmap_init_i2c(client, &adxl313_i2c_regmap_config);
636d4463303934 Lucas Stankus 2021-09-01  30  	if (IS_ERR(regmap)) {
636d4463303934 Lucas Stankus 2021-09-01  31  		dev_err(&client->dev, "Error initializing i2c regmap: %ld\n",
636d4463303934 Lucas Stankus 2021-09-01  32  			PTR_ERR(regmap));
636d4463303934 Lucas Stankus 2021-09-01  33  		return PTR_ERR(regmap);
636d4463303934 Lucas Stankus 2021-09-01  34  	}
636d4463303934 Lucas Stankus 2021-09-01  35  
636d4463303934 Lucas Stankus 2021-09-01 @36  	return adxl313_core_probe(&client->dev, regmap, client->name, NULL);
636d4463303934 Lucas Stankus 2021-09-01  37  }
636d4463303934 Lucas Stankus 2021-09-01  38  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (178110 bytes)