linux-kernel - Re: [PATCH] speakup: Fix compilation in some build environments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220816183214.6atl3g2fndi5jmep@begin>
Date:   Tue, 16 Aug 2022 20:32:14 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Nikita Travkin <nikita@...n.ru>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        speakup@...ux-speakup.org
Subject: Re: [PATCH] speakup: Fix compilation in some build environments

Hello,

Nikita Travkin, le mar. 16 août 2022 12:28:43 +0500, a ecrit:
> -- >8 --
> From bc239d8740f9e31240e8727f76227daa1aec3c4f Mon Sep 17 00:00:00 2001
> From: Nikita Travkin <nikita@...n.ru>
> Date: Tue, 16 Aug 2022 11:39:52 +0500
> 
> A compilation error may occur if the host CC doesn't have u_char
> defined:
> 
>   HOSTCC  drivers/accessibility/speakup/makemapdata.o
> In file included from ../drivers/accessibility/speakup/makemapdata.c:15:
> ../drivers/accessibility/speakup/utils.h: In function 'hash_name':
> ../drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?
>    57 |         u_char *pn = (u_char *)name;
>       |         ^~~~~~
>       |         char
> 
> Fix this by using "unsigned char" instead.
> 
> Fixes: 6a5c94d92699 ("speakup: Generate speakupmap.h automatically")
> Signed-off-by: Nikita Travkin <nikita@...n.ru>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Thanks!

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..4ce9a12f7664 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
>  
>  static inline struct st_key *hash_name(char *name)
>  {
> -	u_char *pn = (u_char *)name;
> +	unsigned char *pn = (unsigned char *)name;
>  	int hash = 0;
>  
>  	while (*pn) {
> -- 
> 2.35.3
>