linux-kernel - Re: [PATCH v10 05/13] nvme: zns: Allow ZNS drives that have non-power_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvwIvrToFYMDwQoj@kbusch-mbp.dhcp.thefacebook.com>
Date:   Tue, 16 Aug 2022 15:14:38 -0600
From:   Keith Busch <kbusch@...nel.org>
To:     Pankaj Raghav <p.raghav@...sung.com>
Cc:     snitzer@...nel.org, axboe@...nel.dk, hch@....de, agk@...hat.com,
        damien.lemoal@...nsource.wdc.com, linux-block@...r.kernel.org,
        Johannes.Thumshirn@....com, bvanassche@....org,
        matias.bjorling@....com, hare@...e.de, gost.dev@...sung.com,
        linux-nvme@...ts.infradead.org, jaegeuk@...nel.org,
        pankydev8@...il.com, linux-kernel@...r.kernel.org,
        dm-devel@...hat.com, Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH v10 05/13] nvme: zns: Allow ZNS drives that have
 non-power_of_2 zone size

On Thu, Aug 11, 2022 at 04:30:35PM +0200, Pankaj Raghav wrote:
> @@ -101,13 +101,6 @@ int nvme_update_zone_info(struct nvme_ns *ns, unsigned lbaf)
>  	}
>  
>  	ns->zsze = nvme_lba_to_sect(ns, le64_to_cpu(id->lbafe[lbaf].zsze));
> -	if (!is_power_of_2(ns->zsze)) {
> -		dev_warn(ns->ctrl->device,
> -			"invalid zone size:%llu for namespace:%u\n",
> -			ns->zsze, ns->head->ns_id);
> -		status = -ENODEV;
> -		goto free_data;
> -	}

We used to bail out early if the format wasn't supported, which wouldn't create
the namespace.

Now you are relying on blk_revalidate_disk_zones() to report an error for
invalid format, but the handling for an error there is different: the namespace
still gets created. I'm not sure if that's a problem, but it's different.