| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Aug 2022 06:07:32 +0800
From: kernel test robot <lkp@...el.com>
To: Hector Martin <marcan@...can.st>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [asahilinux:bits/110-smc 4/17]
drivers/platform/apple/smc_rtkit.c:74:9: error: call to undeclared function
'FIELD_PREP'; ISO C99 and later do not support implicit function
declarations
tree: https://github.com/AsahiLinux/linux bits/110-smc
head: 85225bbe01a2a74102db8d75e316b4e46f1cb07f
commit: 59000ffdca0f77c3f45fe7610510b17382fc8974 [4/17] platform/apple: Add new Apple Mac SMC driver
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220817/202208170620.ruISFGG4-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project aed5e3bea138ce581d682158eb61c27b3cfdd6ec)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/AsahiLinux/linux/commit/59000ffdca0f77c3f45fe7610510b17382fc8974
git remote add asahilinux https://github.com/AsahiLinux/linux
git fetch --no-tags asahilinux bits/110-smc
git checkout 59000ffdca0f77c3f45fe7610510b17382fc8974
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/platform/apple/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
>> drivers/platform/apple/smc_rtkit.c:74:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
msg = (FIELD_PREP(SMC_MSG, SMC_MSG_WRITE_KEY) |
^
>> drivers/platform/apple/smc_rtkit.c:95:6: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (FIELD_GET(SMC_ID, smc->cmd_ret) != smc->msg_id) {
^
>> drivers/platform/apple/smc_rtkit.c:77:20: warning: shift count >= width of type [-Wshift-count-overflow]
FIELD_PREP(SMC_DATA, key));
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:35:22: note: expanded from macro '__GENMASK'
(((~UL(0)) - (UL(1) << (l)) + 1) & \
^ ~~~
>> drivers/platform/apple/smc_rtkit.c:77:20: warning: shift count is negative [-Wshift-count-negative]
FIELD_PREP(SMC_DATA, key));
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:36:11: note: expanded from macro '__GENMASK'
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/apple/smc_rtkit.c:121:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
msg = (FIELD_PREP(SMC_MSG, cmd) |
^
drivers/platform/apple/smc_rtkit.c:139:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (FIELD_GET(SMC_ID, smc->cmd_ret) == smc->msg_id)
^
drivers/platform/apple/smc_rtkit.c:145:11: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
result = FIELD_GET(SMC_RESULT, smc->cmd_ret);
^
drivers/platform/apple/smc_rtkit.c:125:20: warning: shift count >= width of type [-Wshift-count-overflow]
FIELD_PREP(SMC_DATA, arg));
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:35:22: note: expanded from macro '__GENMASK'
(((~UL(0)) - (UL(1) << (l)) + 1) & \
^ ~~~
drivers/platform/apple/smc_rtkit.c:125:20: warning: shift count is negative [-Wshift-count-negative]
FIELD_PREP(SMC_DATA, arg));
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:36:11: note: expanded from macro '__GENMASK'
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/apple/smc_rtkit.c:150:25: warning: shift count >= width of type [-Wshift-count-overflow]
*ret_data = FIELD_GET(SMC_DATA, smc->cmd_ret);
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:35:22: note: expanded from macro '__GENMASK'
(((~UL(0)) - (UL(1) << (l)) + 1) & \
^ ~~~
drivers/platform/apple/smc_rtkit.c:150:25: warning: shift count is negative [-Wshift-count-negative]
*ret_data = FIELD_GET(SMC_DATA, smc->cmd_ret);
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:36:11: note: expanded from macro '__GENMASK'
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/apple/smc_rtkit.c:303:13: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
} else if (FIELD_GET(SMC_MSG, message) == SMC_MSG_NOTIFICATION) {
^
drivers/platform/apple/smc_rtkit.c:327:6: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (FIELD_GET(SMC_MSG, message) != SMC_MSG_NOTIFICATION) {
^
drivers/platform/apple/smc_rtkit.c:332:48: warning: shift count >= width of type [-Wshift-count-overflow]
apple_smc_event_received(smc->core, FIELD_GET(SMC_DATA, message));
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:35:22: note: expanded from macro '__GENMASK'
(((~UL(0)) - (UL(1) << (l)) + 1) & \
^ ~~~
drivers/platform/apple/smc_rtkit.c:332:48: warning: shift count is negative [-Wshift-count-negative]
apple_smc_event_received(smc->core, FIELD_GET(SMC_DATA, message));
^~~~~~~~
drivers/platform/apple/smc_rtkit.c:30:20: note: expanded from macro 'SMC_DATA'
#define SMC_DATA GENMASK(63, 32)
^~~~~~~~~~~~~~~
include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~~~~~~~
include/linux/bits.h:36:11: note: expanded from macro '__GENMASK'
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/apple/smc_rtkit.c:386:12: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
FIELD_PREP(SMC_MSG, SMC_MSG_INITIALIZE), NULL, false);
vim +/FIELD_PREP +74 drivers/platform/apple/smc_rtkit.c
58
59 static int apple_smc_rtkit_write_key_atomic(void *cookie, smc_key key, void *buf, size_t size)
60 {
61 struct apple_smc_rtkit *smc = cookie;
62 int ret;
63 u64 msg;
64 u8 result;
65
66 if (size > SMC_SHMEM_SIZE || size == 0)
67 return -EINVAL;
68
69 if (!smc->alive)
70 return -EIO;
71
72 memcpy_toio(smc->shmem.iomem, buf, size);
73 smc->msg_id = (smc->msg_id + 1) & 0xf;
> 74 msg = (FIELD_PREP(SMC_MSG, SMC_MSG_WRITE_KEY) |
75 FIELD_PREP(SMC_SIZE, size) |
76 FIELD_PREP(SMC_ID, smc->msg_id) |
> 77 FIELD_PREP(SMC_DATA, key));
78 smc->atomic_pending = true;
79
80 ret = apple_rtkit_send_message(smc->rtk, SMC_ENDPOINT, msg, NULL, true);
81 if (ret < 0) {
82 dev_err(smc->dev, "Failed to send command (%d)\n", ret);
83 return ret;
84 }
85
86 while (smc->atomic_pending) {
87 ret = apple_rtkit_poll(smc->rtk);
88 if (ret < 0) {
89 dev_err(smc->dev, "RTKit poll failed (%llx)", msg);
90 return ret;
91 }
92 udelay(100);
93 }
94
> 95 if (FIELD_GET(SMC_ID, smc->cmd_ret) != smc->msg_id) {
96 dev_err(smc->dev, "Command sequence mismatch (expected %d, got %d)\n",
97 smc->msg_id, (unsigned int)FIELD_GET(SMC_ID, smc->cmd_ret));
98 return -EIO;
99 }
100
101 result = FIELD_GET(SMC_RESULT, smc->cmd_ret);
102 if (result != 0)
103 return -result;
104
105 return FIELD_GET(SMC_SIZE, smc->cmd_ret);
106 }
107
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists