linux-kernel - Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Aug 2022 01:21:09 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Sander Vanheule <sander@...nheule.net>,
        René van Dorst <opensource@...rst.com>,
        Daniel Golle <daniel@...rotopia.org>, erkin.bozoglu@...ont.com,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove
 unnecesary lines

On 17.08.2022 00:14, Rob Herring wrote:
> On Sat, Aug 13, 2022 at 06:44:13PM +0300, Arınç ÜNAL wrote:
>> Remove unnecessary lines as they are already included from the referred
>> dsa.yaml.
> 
> You are duplicating the schema and then removing parts twice. I would
> combine patches 4 and 5 or reverse the order.

Will combine.

> 
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
>> ---
>>   .../bindings/net/dsa/mediatek,mt7530.yaml     | 27 -------------------
>>   1 file changed, 27 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> index ff51a2f6875f..a27cb4fa490f 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> @@ -162,15 +162,8 @@ allOf:
>>   
>>         patternProperties:
>>           "^(ethernet-)?ports$":
>> -          type: object
>> -
>>             patternProperties:
>>               "^(ethernet-)?port@[0-9]+$":
>> -              type: object
>> -              description: Ethernet switch ports
>> -
>> -              unevaluatedProperties: false
>> -
>>                 properties:
>>                   reg:
>>                     description:
>> @@ -178,7 +171,6 @@ allOf:
>>                       0 to 5 for user ports.
>>   
>>                 allOf:
>> -                - $ref: dsa-port.yaml#
>>                   - if:
> 
> This 'if' schema is the only part you need actually (though you have to
> create the node structure).

Do you mean that I should take "if:" out of allOf?

> 
>>                       properties:
>>                         label:
>> @@ -186,7 +178,6 @@ allOf:
>>                             - const: cpu
>>                     then:
>>                       required:
>> -                      - reg
>>                         - phy-mode
>>   
>>     - if:
>> @@ -200,15 +191,8 @@ allOf:
>>   
>>         patternProperties:
>>           "^(ethernet-)?ports$":
>> -          type: object
>> -
>>             patternProperties:
>>               "^(ethernet-)?port@[0-9]+$":
>> -              type: object
>> -              description: Ethernet switch ports
>> -
>> -              unevaluatedProperties: false
>> -
>>                 properties:
>>                   reg:
>>                     description:
>> @@ -216,7 +200,6 @@ allOf:
>>                       0 to 5 for user ports.
>>   
>>                 allOf:
>> -                - $ref: dsa-port.yaml#
>>                   - if:
>>                       properties:
>>                         label:
>> @@ -224,7 +207,6 @@ allOf:
>>                             - const: cpu
>>                     then:
>>                       required:
>> -                      - reg
>>                         - phy-mode
>>   
>>     - if:
>> @@ -238,15 +220,8 @@ allOf:
>>   
>>         patternProperties:
>>           "^(ethernet-)?ports$":
>> -          type: object
>> -
>>             patternProperties:
>>               "^(ethernet-)?port@[0-9]+$":
>> -              type: object
>> -              description: Ethernet switch ports
>> -
>> -              unevaluatedProperties: false
>> -
>>                 properties:
>>                   reg:
>>                     description:
>> @@ -254,7 +229,6 @@ allOf:
>>                       0 to 5 for user ports.
>>   
>>                 allOf:
>> -                - $ref: dsa-port.yaml#
>>                   - if:
>>                       properties:
>>                         label:
>> @@ -262,7 +236,6 @@ allOf:
>>                             - const: cpu
>>                     then:
>>                       required:
>> -                      - reg
>>                         - phy-mode
>>   
>>   unevaluatedProperties: false
>> -- 
>> 2.34.1
>>
>>