linux-kernel - Re: [PATCH v2] docs: admin-guide/mm: Improve grammar on MM concepts documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Aug 2022 15:36:32 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     alexlzhu@...com, corbet@....net, bobwxc@...il.cn, rppt@...nel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kernel-team@...com
Subject: Re: [PATCH v2] docs: admin-guide/mm: Improve grammar on MM concepts
 documentation

Hi--

On 8/15/22 19:26, alexlzhu@...com wrote:
> From: Alexander Zhu <alexlzhu@...com>
> 
> Improve grammar on MM concepts documentation.
> 
> Signed-off-by: Alexander Zhu <alexlzhu@...com>
> ---
>  Documentation/admin-guide/mm/concepts.rst | 138 +++++++++++-----------
>  1 file changed, 68 insertions(+), 70 deletions(-)
> 
> diff --git a/Documentation/admin-guide/mm/concepts.rst b/Documentation/admin-guide/mm/concepts.rst
> index c79f1e336222..c471f80b7a38 100644
> --- a/Documentation/admin-guide/mm/concepts.rst
> +++ b/Documentation/admin-guide/mm/concepts.rst

[snip]

> -Depending on the page usage it is treated differently by the Linux
> -memory management. The pages that can be freed at any time, either
> -because they cache the data available elsewhere, for instance, on a
> -hard disk, or because they can be swapped out, again, to the hard
> +Depending on page usage it is treated differently by the Linux
> +memory management subsystem. Pages that can be freed at any time,
> +either because they cache the data available elsewhere
> +(ie on a hard disk) or because they can be swapped out to the hard

   (i.e., on a hard disk)

>  disk, are called `reclaimable`. The most notable categories of the
>  reclaimable pages are page cache and anonymous memory.
>  

[snip]

>  
>  Compaction
>  ==========
>  
> -As the system runs, tasks allocate and free the memory and it becomes
> +As the system runs, tasks will allocate and free memory. Memory thus becomes

Addition of "will" is not needed.

>  fragmented. Although with virtual memory it is possible to present
> -scattered physical pages as virtually contiguous range, sometimes it is
> +scattered physical pages as a virtually contiguous range, sometimes it is
>  necessary to allocate large physically contiguous memory areas. Such
>  need may arise, for instance, when a device driver requires a large
>  buffer for DMA, or when THP allocates a huge page. Memory `compaction`

Thanks.
-- 
~Randy