linux-kernel - Re: [PATCH v3 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_N2EToKQG7xS6NOTvgLrVuzWTtqZgHbF6LEOH3gZdHhgQ@mail.gmail.com>
Date:   Mon, 15 Aug 2022 16:44:33 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     André Almeida <andrealmeid@...lia.com>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Pan Xinhui <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Hawking Zhang <Hawking.Zhang@....com>,
        Tao Zhou <tao.zhou1@....com>,
        Felix Kuehling <Felix.Kuehling@....com>,
        Jack Xiao <Jack.Xiao@....com>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Tom St Denis <tom.stdenis@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        kernel-dev@...lia.com
Subject: Re: [PATCH v3 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx

Applied the series.  Thanks!

Alex

On Wed, Aug 10, 2022 at 7:30 PM André Almeida <andrealmeid@...lia.com> wrote:
>
> Add comments to document gfx_off related members of struct amdgpu_gfx.
>
> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> index 1b8b4a5270c9..8abdf41d0f83 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> @@ -332,12 +332,12 @@ struct amdgpu_gfx {
>         uint32_t                        srbm_soft_reset;
>
>         /* gfx off */
> -       bool                            gfx_off_state; /* true: enabled, false: disabled */
> -       struct mutex                    gfx_off_mutex;
> -       uint32_t                        gfx_off_req_count; /* default 1, enable gfx off: dec 1, disable gfx off: add 1 */
> -       struct delayed_work             gfx_off_delay_work;
> -       uint32_t                        gfx_off_residency;
> -       uint64_t                        gfx_off_entrycount;
> +       bool                            gfx_off_state;      /* true: enabled, false: disabled */
> +       struct mutex                    gfx_off_mutex;      /* mutex to change gfxoff state */
> +       uint32_t                        gfx_off_req_count;  /* default 1, enable gfx off: dec 1, disable gfx off: add 1 */
> +       struct delayed_work             gfx_off_delay_work; /* async work to set gfx block off */
> +       uint32_t                        gfx_off_residency;  /* last logged residency */
> +       uint64_t                        gfx_off_entrycount; /* count of times GPU has get into GFXOFF state */
>
>         /* pipe reservation */
>         struct mutex                    pipe_reserve_mutex;
> --
> 2.37.1
>