lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Aug 2022 21:10:12 +0000 From: Dexuan Cui <decui@...rosoft.com> To: Bjorn Helgaas <helgaas@...nel.org> CC: "quic_jhugo@...cinc.com" <quic_jhugo@...cinc.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, KY Srinivasan <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Stephen Hemminger <sthemmin@...rosoft.com>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Michael Kelley (LINUX)" <mikelley@...rosoft.com>, "robh@...nel.org" <robh@...nel.org>, "kw@...ux.com" <kw@...ux.com>, "alex.williamson@...hat.com" <alex.williamson@...hat.com>, "boqun.feng@...il.com" <boqun.feng@...il.com>, Boqun Feng <Boqun.Feng@...rosoft.com>, Carl Vanderlip <quic_carlv@...cinc.com> Subject: RE: [PATCH] PCI: hv: Fix the definiton of vector in hv_compose_msi_msg() > From: Bjorn Helgaas <helgaas@...nel.org> > Sent: Monday, August 15, 2022 1:36 PM > To: Dexuan Cui <decui@...rosoft.com> > > s/definiton/definition/ in subject > (only if you have other occasion to repost this) Thanks, Bjorn! I suppose Wei can help fix this. :-) > On Mon, Aug 15, 2022 at 11:55:05AM -0700, Dexuan Cui wrote: > > The local variable 'vector' must be u32 rather than u8: see the > > struct hv_msi_desc3. > > > > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc, > > hv_msi_desc2 and hv_msi_desc3. > > > > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI") > > Signed-off-by: Dexuan Cui <decui@...rosoft.com> > > Cc: Jeffrey Hugo <quic_jhugo@...cinc.com> > > Cc: Carl Vanderlip <quic_carlv@...cinc.com> > > Looks like Wei has been applying most changes to pci-hyperv.c, so I > assume the same will happen here. So I interpret this as an ack for Wei to apply the earlier patch [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI and this patch. The two small patches are pure Hyper-V specific changes, so IMO it's better for them to go through Wei's Hyper-V tree rather than the PCI tree. (It looks like the PCI folks are too busy right now) > > --- > > > > The patch should be appplied after the earlier patch: > > [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI
Powered by blists - more mailing lists