linux-kernel - Re: [PATCH V8 0/4] Add unit test module for AMD P-State driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Aug 2022 16:54:16 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Meng Li <li.meng@....com>, Huang Rui <ray.huang@....com>,
        linux-pm@...r.kernel.org
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Nathan Fontenot <nathan.fontenot@....com>,
        Deepak Sharma <deepak.sharma@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        Jinzhou Su <Jinzhou.Su@....com>,
        Perry Yuan <Perry.Yuan@....com>,
        Xiaojian Du <Xiaojian.Du@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Borislav Petkov <bp@...en8.de>, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH V8 0/4] Add unit test module for AMD P-State driver

On 6/9/22 2:28 PM, Shuah Khan wrote:
> On 5/26/22 9:44 AM, Shuah Khan wrote:
>> On 5/25/22 9:47 PM, Meng Li wrote:
>>> Hi all:
>>>
>>> AMD P-State unit test(amd-pstate-ut) is a kernel module for testing
>>> the functions of amd-pstate driver.
>>> It could import as a module to launch some test tasks.
>>> 1) It can help all users to verify their processor support (SBIOS/
>>> Firmware or Hardware).
>>> 2) Kernel can have a basic function test to avoid the kernel regression
>>> during the update.
>>> 3) We can introduce more functional or performance tests to align the
>>> together, it will benefit power and performance scale optimization.
>>>
>>> We upstream out AMD P-state driver into Linux kernel and use this unit
>>> test module to verify the required conditions and basic functions of
>>> amd-pstate before integration test.
>>>
>>> We use test module in the kselftest frameworks to implement it.
>>> We create amd-pstate-ut module and tie it into kselftest.
>>>
>>> For example: The test case aput_acpi_cpc is used to check whether the
>>> _CPC object is exist in SBIOS.
>>> The amd-pstate initialization will fail if the _CPC in ACPI SBIOS is not
>>> existed at the detected processor, so it is a necessary condition.
>>>
>>> At present, it only implements the basic framework and some simple test
>>> cases.
>>>
>>> TODO : 1) we will add more test cases to improve the depth and coverage of
>>> the test. E.X. use the script to trigger the tbench, gitsource, kernbench,
>>> netperf, speedometer, and etc. testing and monitor the cpu frequency and
>>> performance goals change, power consumption at runtime.
>>>
>>> Please check the documentation amd-pstate.rst for details of the test steps.
>>>
>>> See patch series in below git repo:
>>> V1: https://lore.kernel.org/linux-pm/20220323071502.2674156-1-li.meng@amd.com/
>>> V2: https://lore.kernel.org/lkml/20220413090510.4039589-1-li.meng@amd.com/
>>> V3: https://lore.kernel.org/lkml/20220421074152.599419-1-li.meng@amd.com/
>>> V4: https://lore.kernel.org/lkml/20220427135315.3447550-1-li.meng@amd.com/
>>> V5: https://lore.kernel.org/lkml/20220505022913.329259-1-li.meng@amd.com/
>>> V6: https://lore.kernel.org/lkml/20220519134737.359290-1-li.meng@amd.com/
>>> V7: https://lore.kernel.org/lkml/20220522115423.1147282-1-li.meng@amd.com/
>>>
>>
>>>
>>> Changes from V7 -> V8:
>>> - cpufreq: amd-pstate:
>>> - - amend commit message.
>>> - - amend module description.
>>> - Documentation: amd-pstate:
>>> - - amend commit message.
>>> - - Remove the personal data.
>>>
>>
>> Looks good to me. Thank you.
>>
>> Rafael, Viresh,
>>
>> How do you want to handle this patch series? We are in merge window
>> and this would be for Linux 5.20 based on the changes and content.
>>
>> Would you like to take the entire patch series through your tree, you
>> have my Ack(s) and Reviewed-by(s)
>>
> 
> Picking this back up since rc1 is out. How do we want to handle this patch
> series?
> 

Please send me rebased version. I will apply it for the net release.

thanks,
-- Shuah