linux-kernel - Re: [PATCH] ARM: Fix double word in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca6e9b7c-416d-dac4-7855-aa22fde3ef8c@arm.com>
Date:   Tue, 16 Aug 2022 00:21:12 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Xin Gao <gaoxin@...rlc.com>, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr
Cc:     linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: Fix double word in comments

On 2022-08-15 21:00, Xin Gao wrote:
> Delete repeated word "in" in comments.

It is not grammatically incorrect though. The second "in" is the 
preposition here, while the first is an adverb - "fill in" is a term in 
its own right, particularly in the context of information, whereas 
"fill" tends to suggest a more physical context. For instance, one might 
typically say "I filled the bottle" (with liquid), but "I filled in the 
application form" (with data).

Robin.

> Signed-off-by: Xin Gao <gaoxin@...rlc.com>
> ---
>   arch/arm/mach-pxa/palm27x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c
> index 1a8d25eecac3..116183859357 100644
> --- a/arch/arm/mach-pxa/palm27x.c
> +++ b/arch/arm/mach-pxa/palm27x.c
> @@ -160,7 +160,7 @@ void __init palm27x_lcd_init(int power, struct pxafb_mode_info *mode)
>   #if	defined(CONFIG_USB_PXA27X) || \
>   	defined(CONFIG_USB_PXA27X_MODULE)
>   
> -/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
> +/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
>   static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
>   	.dev_id = "gpio-vbus",
>   	.table = {