linux-kernel - Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1369566-6459-2eae-35f4-818865a7df20@huawei.com>
Date:   Wed, 17 Aug 2022 10:48:47 +0800
From:   Sun Ke <sunke32@...wei.com>
To:     Gao Xiang <hsiangkao@...ux.alibaba.com>
CC:     <xiang@...nel.org>, <chao@...nel.org>,
        <linux-erofs@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <yinxin.x@...edance.com>
Subject: Re: [PATCH] erofs: fix error return code in
 erofs_fscache_meta_read_folio and erofs_fscache_read_folio



在 2022/8/17 10:41, Gao Xiang 写道:
> Hi Ke,
> 
> On Wed, Aug 17, 2022 at 09:44:46AM +0800, Sun Ke wrote:
>>
>>
>> 在 2022/8/16 13:16, Gao Xiang 写道:
>>> On Mon, Aug 15, 2022 at 11:48:29AM +0800, Sun Ke wrote:
>>>> If erofs_fscache_alloc_request fail and then goto out, it will return 0.
>>>> it should return a negative error code instead of 0.
>>>>
>>>> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead")
>>>> Signed-off-by: Sun Ke <sunke32@...wei.com>
>>>
>>> Minor, I tried to apply this patch by updating the patch title into
>>> "erofs: fix error return code in erofs_fscache_{meta_,}read_folio"
>>>
>>> since the original patch title is too long.
>>
>> Should I send a v2 patch to update the title?
> 
> I've already updated this by hand if you have no concern ;)
> will push out to -next today...
;)

Thanks,
Sun Ke
> 
> Thanks,
> Gao Xiang
> 
>>
>> Thanks,
>> Sun Ke
>>>
>>> Thanks,
>>> Gao Xiang
>>> .
>>>
> .
>