linux-kernel - Re: [RFT PATCH v2 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd1492fa-4244-b283-d2a6-b4ffac7d53d6@somainline.org>
Date:   Wed, 17 Aug 2022 22:57:51 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH v2 02/14] arm64: dts: qcom: msm8996: split TCSR halt
 regs out of mutex



On 17.08.2022 15:03, Krzysztof Kozlowski wrote:
> The TCSR halt regs are next to TCSR mutex, so before converting the TCSR
> mutex into device with address space, we need to split the halt regs to
> its own syscon device.  This also describes more accurately the devices
> and their IO address space.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Not tested on a device, but looks good to the eye:
Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

On a note, are they really named TCSR_1 and TCSR_2 in the docs?
Qualcomm is usually more exquisite in their naming :P

Konrad
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 742eac4ce9b3..3411ced96db6 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -359,7 +359,7 @@ opp-2150400000 {
>  	firmware {
>  		scm {
>  			compatible = "qcom,scm-msm8996", "qcom,scm";
> -			qcom,dload-mode = <&tcsr 0x13000>;
> +			qcom,dload-mode = <&tcsr_2 0x13000>;
>  		};
>  	};
>  
> @@ -840,10 +840,15 @@ pnoc: interconnect@...000 {
>  
>  		tcsr_mutex_regs: syscon@...000 {
>  			compatible = "syscon";
> -			reg = <0x00740000 0x40000>;
> +			reg = <0x00740000 0x20000>;
>  		};
>  
> -		tcsr: syscon@...000 {
> +		tcsr_1: sycon@...000 {
> +			compatible = "qcom,tcsr-msm8996", "syscon";
> +			reg = <0x00760000 0x20000>;
> +		};
> +
> +		tcsr_2: syscon@...000 {
>  			compatible = "qcom,tcsr-msm8996", "syscon";
>  			reg = <0x007a0000 0x18000>;
>  		};
> @@ -2413,7 +2418,7 @@ mss_pil: remoteproc@...0000 {
>  			qcom,smem-states = <&mpss_smp2p_out 0>;
>  			qcom,smem-state-names = "stop";
>  
> -			qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>;
> +			qcom,halt-regs = <&tcsr_1 0x3000 0x5000 0x4000>;
>  
>  			status = "disabled";
>