linux-kernel - Re: [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Aug 2022 21:24:52 +0000
From:   Mirela Rabulea <mirela.rabulea@....com>
To:     "mchehab@...nel.org" <mchehab@...nel.org>,
        Ming Qian <ming.qian@....com>,
        "Mirela Rabulea (OSS)" <mirela.rabulea@....nxp.com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "X.H. Bao" <xiahong.bao@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] media: imx-jpeg: Disable useless interrupt to avoid
 kernel panic

On Thu, 2022-08-04 at 17:38 +0800, Ming Qian wrote:
> There is a hardware bug that the interrupt STMBUF_HALF may be
> triggered
> after or when disable interrupt.
> It may led to unexpected kernel panic.
> And interrupt STMBUF_HALF and STMBUF_RTND have no other effect.
> So disable them and the unused interrupts.
> 
> meanwhile clear the interrupt status when disable interrupt.
> 
> Signed-off-by: Ming Qian <ming.qian@....com>

Reviewed-by: Mirela Rabulea <mirela.rabulea@....com>

> ---
>  drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> index 9418fcf740a8..ef28122a5ed4 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> @@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void
> __iomem *reg)
>  
>  void mxc_jpeg_enable_irq(void __iomem *reg, int slot)
>  {
> -	writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> +	writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
> +	writel(0xF0C, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
>  }
>  
>  void mxc_jpeg_disable_irq(void __iomem *reg, int slot)
>  {
>  	writel(0x0, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> +	writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
>  }
>  
>  void mxc_jpeg_sw_reset(void __iomem *reg)