linux-kernel - Re: [PATCH v6 0/9] Improve MCP3911 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35973b74-f8f2-f953-f937-365acb67db43@linaro.org>
Date:   Wed, 17 Aug 2022 09:12:32 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Marcus Folkesson <marcus.folkesson@...il.com>
Cc:     Kent Gustavsson <kent@...oris.se>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/9] Improve MCP3911 driver

On 16/08/2022 17:57, Marcus Folkesson wrote:
> On Tue, Aug 16, 2022 at 01:22:31PM +0300, Krzysztof Kozlowski wrote:
>> On 15/08/2022 09:16, Marcus Folkesson wrote:
>>> v5:
>>> - Drop remove function
>>> - Split tx&rx transfers in mcp3911_trigger_handler()
>>> - Moved Kconfig changes to right patch
>>>
>>> v6:
>>> - Go for devm_clk_get_enabled()
>>> - Cosmetic cleanups
>>> - Clarify the description of microchip,data-ready-hiz
>>>
>>
>> Please include the diffstat (format-patch does it for you, but if you
>> prefer to use other tools - it's your job).
> 
> I'm sorry, I do not get you.
> The diffstat is included in the patches, should it be included here as
> well?

Yes, in the cover letter, so when someone partially interested (e.g. me)
opens the cover letter, it's easy to notice what files are affected.

Again, this is exactly what Git is doing, so you have to on purpose use
less-standard process to achieve cover letter without diffstat.

Best regards,
Krzysztof