lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Aug 2022 08:31:20 +0200 From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> To: Khalid Masum <khalid.masum.92@...il.com>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org Cc: Vinod Koul <vkoul@...nel.org>, Bard Liao <yung-chuan.liao@...ux.intel.com>, Sanyog Kale <sanyog.r.kale@...el.com> Subject: Re: [PATCH v2 linux-next] Remove Unnecessary TODO On 8/16/22 19:59, Khalid Masum wrote: > The capabilities enabled for multi-link are required as part of the > programming sequences, even when a stream uses a single link we still > use the syncArm/syncGo sequences. Therefore the TODO is no longer > necessary. > > Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> > Signed-off-by: Khalid Masum <khalid.masum.92@...il.com> the title of your patch should be something like soundwire: intel: remove unnecessary TODO so that the patch scope and context is clearly identified. > --- > Previous discussions: > - v1 Link: https://lore.kernel.org/lkml/20220814080416.7531-1-khalid.masum.92@gmail.com/ > > Changes since v1: > - Remove the todo, leave rest of the code as is > - Update commit message > > drivers/soundwire/bus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index 8d4000664fa3..18158825a6d8 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent, > > /* > * Initialize multi_link flag > - * TODO: populate this flag by reading property from FW node > */ > bus->multi_link = false; > if (bus->ops->read_prop) {
Powered by blists - more mailing lists