linux-kernel - Re: [PATCH v11 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab3ef674-c453-5b38-80b5-f41dcfed62bb@samsung.com>
Date:   Wed, 17 Aug 2022 09:35:55 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <axboe@...nel.dk>, <snitzer@...nel.org>, <hch@....de>,
        <agk@...hat.com>
CC:     <pankydev8@...il.com>, <gost.dev@...sung.com>,
        <matias.bjorling@....com>, <hare@...e.de>, <bvanassche@....org>,
        <linux-kernel@...r.kernel.org>, <dm-devel@...hat.com>,
        <linux-nvme@...ts.infradead.org>, <jaegeuk@...nel.org>,
        <Johannes.Thumshirn@....com>, <linux-block@...r.kernel.org>,
        Damien Le Moal <damien.lemoal@....com>
Subject: Re: [PATCH v11 13/13] dm: add power-of-2 target for zoned devices
 with non power-of-2 zone sizes

Hi Damien,
>> + */
>> +static bool bio_in_emulated_zone_area(struct dm_po2z_target *dmh,
>> +				      struct bio *bio, int *offset)
> 
> This function name reads like it is a block layer helper. It mat be less
> confucing to keep using the dm_po2z_ prefix for it.
>
Good point. Even though it is a static function in the same file, it could
be confused for a block helper at the caller site.
>> +{
>> +	/*
>> +	 * Read operation on the emulated zone area (between zone capacity
>> +	 * and zone size) will fill the bio with zeroes. Any other operation

>> +
>> +	return DM_MAPIO_KILL;
>> +}
> 
Do you see any more issues apart from the two you pointed out?