linux-kernel - Re: [PATCH -next 2/2] PCI: switch to use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fce4a8ca-5429-22ea-b601-bae4299ac8c0@wanadoo.fr>
Date:   Wed, 17 Aug 2022 11:11:04 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Cc:     bhelgaas@...gle.com
Subject: Re: [PATCH -next 2/2] PCI: switch to use dev_err_probe()

Le 17/08/2022 à 10:44, Yang Yingliang a écrit :
> Use dev_err_probe() to simplify code and print error code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>   drivers/pci/probe.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 0e947f24153e..f2430da8a30b 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -3054,10 +3054,9 @@ int pci_host_probe(struct pci_host_bridge *bridge)
>   	int ret;
>   
>   	ret = pci_scan_root_bus_bridge(bridge);
> -	if (ret < 0) {
> -		dev_err(bridge->dev.parent, "Scanning root bridge failed");
> -		return ret;
> -	}
> +	if (ret < 0)
> +		return dev_err_probe(bridge->dev.parent, ret,
> +				     "Scanning root bridge failed");
>   
>   	bus = bridge->bus;
>   

Nit: you could also add a \n at the end of the message.

Just my 2c,

CJ