linux-kernel - Re: [PATCH v6 1/2] fpga: ecp5-spi: add Lattice ECP5 FPGA manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Aug 2022 12:04:13 +0300
From:   Ivan Bornyakov <i.bornyakov@...rotek.ru>
To:     Xu Yilun <yilun.xu@...el.com>
Cc:     mdf@...nel.org, hao.wu@...el.com, trix@...hat.com, dg@...ix.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-fpga@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, system@...rotek.ru
Subject: Re: [PATCH v6 1/2] fpga: ecp5-spi: add Lattice ECP5 FPGA manager

On Tue, Aug 16, 2022 at 02:09:18PM +0800, Xu Yilun wrote:
> On 2022-08-16 at 07:58:41 +0300, Ivan Bornyakov wrote:
> > On Tue, Aug 16, 2022 at 10:00:41AM +0800, Xu Yilun wrote:
> > > On 2022-08-15 at 16:21:56 +0300, Ivan Bornyakov wrote:
> > > > Add support to the FPGA manager for programming Lattice ECP5 FPGA over
> > > > slave SPI interface with .bit formatted uncompressed bitstream image.
> > > 
> > > Not sure if something is missed.
> > > 
> > > https://lore.kernel.org/all/20220729145757.GA2601292@yilunxu-OptiPlex-7050/
> > > 
> > > I was considering if a generic driver for lattice slave SPI sysCONFIG
> > > interface could be introduced. From machxo2 & ecp5 Programming Usage
> > > Guide, or others in this series, they basically use the same reconfigure
> > > interface & protocol.
> > > 
> > > Thanks,
> > > Yilun
> > > 
> > 
> > I only have HW with ECP5, can't vouch for the rest.
> 
> I understand your concern, but having separate drivers for the same IP on
> different boards makes the maintaining harder.
> 
> We don't have to make everything fine, but start with machxo2 and ecp5
> first. If the change affects machxo2, other people may help.
> 
> Thanks,
> Yilun
> 

Hi, Yilun.

To clear things out, considering what Daniel said in
https://lore.kernel.org/linux-fpga/20220816074216.GA31706@homes.emlix.com/
you still don't want separate ECP5 driver, or this v6 is OK and review
continues?