linux-kernel - RE: [PATCH v2 1/3] fpga: manager: change status api prototype, don't use older

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB39934EC6FB92A46CEA8645E5CD6A9@DM6PR12MB3993.namprd12.prod.outlook.com>
Date:   Wed, 17 Aug 2022 11:16:14 +0000
From:   "Manne, Nava kishore" <nava.kishore.manne@....com>
To:     Xu Yilun <yilun.xu@...el.com>,
        Nava kishore Manne <nava.manne@...inx.com>
CC:     "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "hao.wu@...el.com" <hao.wu@...el.com>,
        "trix@...hat.com" <trix@...hat.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "ronak.jain@...inx.com" <ronak.jain@...inx.com>,
        "rajan.vaja@...inx.com" <rajan.vaja@...inx.com>,
        "abhyuday.godhasara@...inx.com" <abhyuday.godhasara@...inx.com>,
        "piyush.mehta@...inx.com" <piyush.mehta@...inx.com>,
        "harsha.harsha@...inx.com" <harsha.harsha@...inx.com>,
        "lakshmi.sai.krishna.potthuri@...inx.com" 
        <lakshmi.sai.krishna.potthuri@...inx.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "git@...inx.com" <git@...inx.com>
Subject: RE: [PATCH v2 1/3] fpga: manager: change status api prototype, don't
 use older

Hi Yilun,

	Please find my response inline.

> -----Original Message-----
> From: Xu Yilun <yilun.xu@...el.com>
> Sent: Tuesday, June 28, 2022 2:02 PM
> To: Nava kishore Manne <nava.manne@...inx.com>
> Cc: michal.simek@...inx.com; hao.wu@...el.com; trix@...hat.com;
> mdf@...nel.org; gregkh@...uxfoundation.org; ronak.jain@...inx.com;
> rajan.vaja@...inx.com; abhyuday.godhasara@...inx.com;
> piyush.mehta@...inx.com; harsha.harsha@...inx.com;
> lakshmi.sai.krishna.potthuri@...inx.com; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux-
> fpga@...r.kernel.org; git@...inx.com
> Subject: Re: [PATCH v2 1/3] fpga: manager: change status api prototype,
> don't use older
> 
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
> 
> 
> On Tue, Jun 21, 2022 at 02:58:31PM +0530, Nava kishore Manne wrote:
> > Different vendors have different error sets defined by Hardware.
> > If we always define the new bits when we cannot find an exact 1:1
> > mapping in the core the 64 bits would soon be used out. Also, it's
> > hard to understand the mixture of different error sets.
> >
> > To address these issues updated the status interface to handle the
> > vendor-specific messages in a generic way. With the updated status
> > interface the vendor-specific driver files can independently handle
> > the error messages.
> 
> I think we don't have to provide the vendor specific HW errors in a generic
> way, maybe the vendor specific drivers could handle them by its own device
> attributes.
> 
> Since the output value set of the interface is specific to each driver, users
> should still interpret them in specific manners. So doesn't see much value for
> a class interface.
>

Agree,  vendor specific drivers could handle them by its own device attributes.
If it is the case, can we remove the existing status interface relevant changes from the core?

Regards,
Navakishore