linux-kernel - Re: [PATCH -next 2/3] block, bfq: remove useless checking in bfq_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220817115420.dmzldiybx5xs4wqf@quack3>
Date:   Wed, 17 Aug 2022 13:54:20 +0200
From:   Jan Kara <jack@...e.cz>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     jack@...e.cz, axboe@...nel.dk, paolo.valente@...aro.org,
        cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yukuai3@...wei.com,
        yi.zhang@...wei.com
Subject: Re: [PATCH -next 2/3] block, bfq: remove useless checking in
 bfq_put_queue()

On Tue 16-08-22 09:56:30, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> 'bfqq->bfqd' is ensured to set in bfq_init_queue(), and it will never
> change afterwards.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  block/bfq-iosched.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index c740b41fe0a4..f39067389b2b 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -5255,9 +5255,7 @@ void bfq_put_queue(struct bfq_queue *bfqq)
>  	struct hlist_node *n;
>  	struct bfq_group *bfqg = bfqq_group(bfqq);
>  
> -	if (bfqq->bfqd)
> -		bfq_log_bfqq(bfqq->bfqd, bfqq, "put_queue: %p %d",
> -			     bfqq, bfqq->ref);
> +	bfq_log_bfqq(bfqq->bfqd, bfqq, "put_queue: %p %d", bfqq, bfqq->ref);
>  
>  	bfqq->ref--;
>  	if (bfqq->ref)
> @@ -5321,7 +5319,7 @@ void bfq_put_queue(struct bfq_queue *bfqq)
>  		hlist_del_init(&item->woken_list_node);
>  	}
>  
> -	if (bfqq->bfqd && bfqq->bfqd->last_completed_rq_bfqq == bfqq)
> +	if (bfqq->bfqd->last_completed_rq_bfqq == bfqq)
>  		bfqq->bfqd->last_completed_rq_bfqq = NULL;
>  
>  	kmem_cache_free(bfq_pool, bfqq);
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR