linux-kernel - Re: [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <601d9f11-254b-ece9-df61-e6a352f520d0@linaro.org>
Date:   Wed, 17 Aug 2022 13:24:51 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Kenneth Lee <klee33@...edu>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one
 element



On 10/08/2022 04:10, Kenneth Lee wrote:
> Use kzalloc(...) rather than kcalloc(1, ...) because the number of
> elements we are specifying in this case is 1, so kzalloc would
> accomplish the same thing and we can simplify.
> 
> Signed-off-by: Kenneth Lee <klee33@...edu>
> ---

Applied thanks,

--srini
>   drivers/nvmem/brcm_nvram.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
> index 450b927691c3..4441daa20965 100644
> --- a/drivers/nvmem/brcm_nvram.c
> +++ b/drivers/nvmem/brcm_nvram.c
> @@ -96,7 +96,7 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
>   
>   	len = le32_to_cpu(header.len);
>   
> -	data = kcalloc(1, len, GFP_KERNEL);
> +	data = kzalloc(len, GFP_KERNEL);
>   	memcpy_fromio(data, priv->base, len);
>   	data[len - 1] = '\0';
>