linux-kernel - [PATCH] perf evsel: Update the hint for the usage of the load latency event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 17 Aug 2022 05:40:50 -0700
From:   kan.liang@...ux.intel.com
To:     acme@...hat.com, linux-kernel@...r.kernel.org
Cc:     eranian@...gle.com, ak@...ux.intel.com, namhyung@...nel.org,
        irogers@...gle.com, Kan Liang <kan.liang@...ux.intel.com>
Subject: [PATCH] perf evsel: Update the hint for the usage of the load latency event

From: Kan Liang <kan.liang@...ux.intel.com>

The current message is not providing enough information. It's hard for
a user to figure out what's the auxiliary event.

Adding the event name of the auxiliary event in the hint. The user can
simply cut & paste.

Suggested-by: Stephane Eranian <eranian@...gle.com>
Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
---
 tools/perf/util/evsel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 4852089e1d79..0d1bb5c723e9 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3056,7 +3056,8 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
 		break;
 	case ENODATA:
 		return scnprintf(msg, size, "Cannot collect data source with the load latency event alone. "
-				 "Please add an auxiliary event in front of the load latency event.");
+				 "Please add an auxiliary event in front of the load latency event. "
+				 "For example, -e {mem-loads-aux,%s}.", evsel__name(evsel));
 	default:
 		break;
 	}
-- 
2.35.1