linux-kernel - Re: [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Aug 2022 05:47:48 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Duke Du <dukedu83@...il.com>, jdelvare@...e.com, corbet@....net,
        linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, fran.hsu@...ntatw.com,
        charles.hsu@...ntatw.com, george.hung@...ntatw.com,
        duke.du@...ntatw.com
Subject: Re: [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24
 Buck Converter.

On Wed, Aug 17, 2022 at 07:28:47PM +0700, Bagas Sanjaya wrote:
> On 8/17/22 13:41, Duke Du wrote:
> > make the PMBUS_VOUT_MODE return value 0x17,
> > VOUT returned value is linear11.
> > 
> > V2: Correct the tps546d24.rst format.
> > 
> > v1: Initial patchset.
> > 
> 
> Seems like the patch description is just the changelog, which
> should have been put between the dashes and diffstat. I would
> like to see the proper description.
> 
Same here. The description doesn't mean anything, should
be a comment in the code, and, yes, the change log should
not be part of the description but follow after '---'.

Guenter