linux-kernel - Re: [PATCH] spi: amd: Configure device speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e2a0f50-c396-5af6-5cbe-303978378587@collabora.com>
Date:   Wed, 17 Aug 2022 19:40:31 +0530
From:   Shreeya Patel <shreeya.patel@...labora.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     sanju.mehta@....com, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        krisman@...labora.com, alvaro.soliverez@...labora.com,
        Lucas Tanure <tanureal@...nsource.cirrus.com>
Subject: Re: [PATCH] spi: amd: Configure device speed


On 17/08/22 19:14, Mark Brown wrote:
> On Wed, Aug 17, 2022 at 06:48:09PM +0530, Shreeya Patel wrote:
>
>> Create mechanism to configure device clock frequency such
>> that it is the closest frequency supported by the
>> AMD controller.
> You shouldn't use the closest, you should use a frequency which is
> strictly less than the requested one - driving things too fast will
> generally break but too slow is pretty much always fine.
Hi Mark,

yes, the code is actually configuring it to use the frequency which is 
strictly less than the requested one.
I just didn't use the correct words. I will make the change in commit 
message for v2 once you review the patch.


Thanks
Shreeya Patel