linux-kernel - RE: [PATCH 2/2] selftests/sgx: Add SGX selftest augment_via_eaccept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR11MB55915BB75E3A6D266FC8D51DF66A9@DM8PR11MB5591.namprd11.prod.outlook.com>
Date:   Wed, 17 Aug 2022 15:39:36 +0000
From:   "Dhanraj, Vijay" <vijay.dhanraj@...el.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>
CC:     "Chatre, Reinette" <reinette.chatre@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
        Shuah Khan <shuah@...nel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] selftests/sgx: Add SGX selftest
 augment_via_eaccept_long



> -----Original Message-----
> From: Jarkko Sakkinen <jarkko@...nel.org>
> Sent: Wednesday, August 17, 2022 7:39 AM
> To: Dhanraj, Vijay <vijay.dhanraj@...el.com>
> Cc: Chatre, Reinette <reinette.chatre@...el.com>; Dave Hansen
> <dave.hansen@...ux.intel.com>; linux-sgx@...r.kernel.org; Shuah Khan
> <shuah@...nel.org>; open list:KERNEL SELFTEST FRAMEWORK <linux-
> kselftest@...r.kernel.org>; open list <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest
> augment_via_eaccept_long
> 
> On Wed, Aug 17, 2022 at 01:27:38AM +0000, Dhanraj, Vijay wrote:
> > I think changing it to "int i" will cause a buffer overflow with
> > edmm_size being 8GB.
> 
> Hmm.. 'i' iterates segments. Amd I missing something?
> 
> BR, Jarkko

It is also used when iterating over pages to eaccept. This might cause an issue.

	for (i = 0; i < edmm_size; i += 4096) {
		eaccept_op.epc_addr = (uint64_t)(addr + i);

Regards, Vijay