lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Aug 2022 08:52:57 -0700 From: Damien Le Moal <damien.lemoal@...nsource.wdc.com> To: John Garry <john.garry@...wei.com>, jejb@...ux.ibm.com, martin.petersen@...cle.com, jinpu.wang@...ud.ionos.com, yangxingui@...wei.com Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, linuxarm@...wei.com, hare@...e.de Subject: Re: [PATCH v2 0/6] libsas and drivers: NCQ error handling On 2022/08/17 7:52, John Garry wrote: > As reported in [0], the pm8001 driver NCQ error handling more or less > duplicates what libata does in link error handling, as follows: > - abort all commands > - do autopsy with read log ext 10 command > - reset the target to recover > > Indeed for the hisi_sas driver we want to add similar handling for NCQ > errors. > > This series add a new libsas API - sas_ata_device_link_abort() - to handle > host NCQ errors, and fixes up pm8001 and hisi_sas drivers to use it. As > mentioned in the pm8001 changeover patch, I would prefer a better place to > locate the SATA ABORT command (rather that nexus reset callback). > > Damien kindly tested the v1 series for pm8001, but any further pm8001 > testing would be appreciated as I have since tweaked > sas_ata_device_link_abort(). This is because the pm8001 driver hangs on my > arm64 machine read log ext10 command. I will run more tests with this series. > > Finally with these changes we can make the libsas task alloc/free APIs > private, which they should always have been. > > Based on v6.0-rc1 > > [0] https://lore.kernel.org/linux-scsi/8fb3b093-55f0-1fab-81f4-e8519810a978@huawei.com/ > > Changes since v1: > - Rename sas_ata_link_abort() -> sas_ata_device_link_abort() > - Set EH RESET flag in sas_ata_device_link_abort() > - Add Jack's Ack tags > - Rebase > > John Garry (5): > scsi: pm8001: Modify task abort handling for SATA task > scsi: libsas: Add sas_ata_device_link_abort() > scsi: pm8001: Use sas_ata_device_link_abort() to handle NCQ errors > scsi: hisi_sas: Don't issue ATA softreset in hisi_sas_abort_task() > scsi: libsas: Make sas_{alloc, alloc_slow, free}_task() private > > Xingui Yang (1): > scsi: hisi_sas: Add SATA_DISK_ERR bit handling for v3 hw > > drivers/scsi/hisi_sas/hisi_sas_main.c | 5 +- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 22 ++- > drivers/scsi/libsas/sas_ata.c | 11 ++ > drivers/scsi/libsas/sas_init.c | 3 - > drivers/scsi/libsas/sas_internal.h | 4 + > drivers/scsi/pm8001/pm8001_hwi.c | 194 +++++++------------------ > drivers/scsi/pm8001/pm8001_sas.c | 13 ++ > drivers/scsi/pm8001/pm8001_sas.h | 8 +- > drivers/scsi/pm8001/pm80xx_hwi.c | 177 ++-------------------- > include/scsi/libsas.h | 4 - > include/scsi/sas_ata.h | 5 + > 11 files changed, 133 insertions(+), 313 deletions(-) > -- Damien Le Moal Western Digital Research
Powered by blists - more mailing lists