linux-kernel - Re: [PATCH] improve the kernel quality and reduce the amount of BS patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Aug 2022 03:18:04 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Paul Lemmermann <thepaulodoom@...paulodoom.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] improve the kernel quality and reduce the amount of BS
 patches

On Wed, Aug 17, 2022 at 03:09:02AM +0100, Al Viro wrote:
> this idiocy has gone too far    
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

	Seriously, folks - the stream of patches with no better
explanations than "The Most Holy checkpatch.pl Says So, Must Appease
The Spirits" ought to stop.

	If you are changing something, take care to explain _why_
is the change made.  Reference to a tool that has pointed you
towards the location you are changing does not replace that.
checkpatch.pl is a script.  A dumb one.  It's a bunch of heuristics
that correlate with code being potentially fishy and worth looking
into; those are occasionally useful, but it's not an oracle.