linux-kernel - Re: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220818172322.51705-1-sj@kernel.org>
Date:   Thu, 18 Aug 2022 17:23:22 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Xin Hao <xhao@...ux.alibaba.com>
Cc:     sj@...nel.org, akpm@...ux-foundation.org, damon@...ts.linux.dev,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg

Hi Xin,

On Thu, 18 Aug 2022 18:57:32 +0800 Xin Hao <xhao@...ux.alibaba.com> wrote:

> The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of
> 'damon_addr_range', so, there no need to redefine it, just use struct of
> 'damon_addr_range' instead.

Reducing code is always good, thanks.  However, I think the type of the 'start'
and 'end' fields of 'struct damon_addr_range' might be changed in a future.
It's very unlikely, though.  Also, we might add some more fields to the struct
in a future.  After all, the purpose of 'struct damon_addr_range' is not saving
the 'start' and 'end' fields of 'struct resource'.  I'd like to avoid making
any possible dependency here, sorry.

Thanks,
SJ

[...]