linux-kernel - Re: [RESEND PATCH net-next v4 00/25] net: dpaa: Cleanups in preparation for phylink conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f085609c-24c9-a9fb-e714-18ba7f3ef48a@seco.com>
Date:   Thu, 18 Aug 2022 14:37:23 -0400
From:   Sean Anderson <sean.anderson@...o.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        Camelia Groza <camelia.groza@....com>,
        open list <linux-kernel@...r.kernel.org>,
        Madalin Bucur <madalin.bucur@....com>,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Li Yang <leoyang.li@....com>, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org
Subject: Re: [RESEND PATCH net-next v4 00/25] net: dpaa: Cleanups in
 preparation for phylink conversion

Hi Jakub,

On 8/18/22 2:20 PM, Jakub Kicinski wrote:
> On Thu, 18 Aug 2022 12:16:24 -0400 Sean Anderson wrote:
>> This series contains several cleanup patches for dpaa/fman. While they
>> are intended to prepare for a phylink conversion, they stand on their
>> own. This series was originally submitted as part of [1].
> 
> Still over the limit of patches in a patch series, and looks pretty
> easy to chunk up. We review and apply patches in netdev in 1-3 days,
> it really is more efficient to post smaller series. 

Last time I offered to arbitrarily chunk things [1], but I did not receive
a response for 3 weeks.

> And with the other series you sent to the list we have nearly 50
> patches from you queued for review. I don't think this is reasonable,
> people reviewing this code are all volunteers trying to get their
> work done as well :(

These patches have been sent to the list in one form or another since
I first sent out an RFC for DPAA conversion back in June [2]. I have not
substantially modified any of them (although I did add a few more
since v2). It's not like I came up with these just now; I have been
seeking feedback on these series for 2-3 months so far. The only
reviews I have gotten were from Camelia Groza, who has provided some
helpful feedback.

--Sean

[1] https://lore.kernel.org/netdev/51c26e19-e4ea-7596-1147-7d95eec9e6a9@seco.com/
[2] https://lore.kernel.org/netdev/20220617203312.3799646-1-sean.anderson@seco.com/