linux-kernel - Re: [PATCH v2 09/16] hwmon: (mr75203) add VM pre-scalar property for Moortec PVT controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818201138.GA3423710@roeck-us.net>
Date:   Thu, 18 Aug 2022 13:11:38 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eliav Farber <farbere@...zon.com>
Cc:     jdelvare@...e.com, robh+dt@...nel.org, mark.rutland@....com,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, talel@...zon.com, hhhawa@...zon.com,
        jonnyc@...zon.com, hanochu@...zon.com, ronenk@...zon.com,
        itamark@...zon.com, shellykz@...zon.com, shorer@...zon.com,
        amitlavi@...zon.com, almogbs@...zon.com, dwmw@...zon.co.uk,
        rtanwar@...linear.com
Subject: Re: [PATCH v2 09/16] hwmon: (mr75203) add VM pre-scalar property for
 Moortec PVT controller

On Wed, Aug 17, 2022 at 05:43:14AM +0000, Eliav Farber wrote:
> vm-pre-scalar-ch# is a per channel optional parameter that can be
> used to normalzie the voltage output results.
> 
> Signed-off-by: Eliav Farber <farbere@...zon.com>
> ---
>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml        | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 6111b5069b3c..e2a55001eefc 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -56,6 +56,12 @@ properties:
>        A value of 0 means that the entire VM sensor is nou used.
>      $ref: /schemas/types.yaml#definitions/uint8-array
>  
> +  vm-pre-scalar-ch#:

Is that how such properties are implemented ? Seems to me that
results in a lot of decode complexity.

Why not use an array property like the other properties ?

Guenter

> +    description:
> +      vm-active-channels defines the pre-scalar per channel value
> +      used to normalzie the voltage output results.
> +    $ref: /schemas/types.yaml#definitions/uint32
> +
>  required:
>    - compatible
>    - reg
> @@ -68,6 +74,7 @@ additionalProperties:
>    - intel,vm-map
>    - reset-control-skip
>    - vm-active-channels
> +  - vm-pre-scalar-ch#
>  
>  examples:
>    - |
> @@ -82,5 +89,6 @@ examples:
>          clocks = <&osc0>;
>          resets = <&rcu0 0x40 7>;
>          vm-active-channels = [08 10 02];
> +        vm-pre-scalar-ch5 = <2>;
>          #thermal-sensor-cells = <1>;
>      };