lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Aug 2022 15:07:15 -0700 From: Luiz Augusto von Dentz <luiz.dentz@...il.com> To: Wolfram Sang <wsa+renesas@...g-engineering.com> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>, "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org> Subject: Re: [PATCH] Bluetooth: move from strlcpy with unused retval to strscpy Hi Wolfram, On Thu, Aug 18, 2022 at 2:05 PM Wolfram Sang <wsa+renesas@...g-engineering.com> wrote: > > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. The link below doesn't seem to work. > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com> > --- > net/bluetooth/hidp/core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c > index 5940744a8cd8..cc20e706c639 100644 > --- a/net/bluetooth/hidp/core.c > +++ b/net/bluetooth/hidp/core.c > @@ -83,14 +83,14 @@ static void hidp_copy_session(struct hidp_session *session, struct hidp_conninfo > ci->product = session->input->id.product; > ci->version = session->input->id.version; > if (session->input->name) > - strlcpy(ci->name, session->input->name, 128); > + strscpy(ci->name, session->input->name, 128); > else > - strlcpy(ci->name, "HID Boot Device", 128); > + strscpy(ci->name, "HID Boot Device", 128); > } else if (session->hid) { > ci->vendor = session->hid->vendor; > ci->product = session->hid->product; > ci->version = session->hid->version; > - strlcpy(ci->name, session->hid->name, 128); > + strscpy(ci->name, session->hid->name, 128); > } > } > > -- > 2.35.1 > -- Luiz Augusto von Dentz
Powered by blists - more mailing lists