linux-kernel - Re: [PATCH] perf: riscv legacy: fix kerneldoc comment warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 16:01:48 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...osinc.com>
To:     conor.dooley@...rochip.com
CC:     atishp@...shpatra.org, anup@...infault.org,
        Will Deacon <will@...nel.org>, mark.rutland@....com,
        Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        conor.dooley@...rochip.com
Subject:     Re: [PATCH] perf: riscv legacy: fix kerneldoc comment warning

On Fri, 12 Aug 2022 07:35:32 PDT (-0700), conor.dooley@...rochip.com wrote:
> Fix the warning:
> drivers/perf/riscv_pmu_legacy.c:76: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Fixes: 9b3e150e310e ("RISC-V: Add a simple platform driver for RISC-V legacy perf")
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>  drivers/perf/riscv_pmu_legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/perf/riscv_pmu_legacy.c b/drivers/perf/riscv_pmu_legacy.c
> index 342778782359..2c20b0de8cb0 100644
> --- a/drivers/perf/riscv_pmu_legacy.c
> +++ b/drivers/perf/riscv_pmu_legacy.c
> @@ -72,7 +72,7 @@ static void pmu_legacy_ctr_start(struct perf_event *event, u64 ival)
>  	local64_set(&hwc->prev_count, initial_val);
>  }
>
> -/**
> +/*
>   * This is just a simple implementation to allow legacy implementations
>   * compatible with new RISC-V PMU driver framework.
>   * This driver only allows reading two counters i.e CYCLE & INSTRET.

Thanks, this is on riscv/fixes -- given how trivial the actual diff is 
I'm OK just taking it without the Ack/Review from anyone else, doubly so 
because I probably broke it the first place.