linux-kernel - Re: [PATCH v3] platform/chrome: cros_ec: Send host event for prepare/complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yv27K4+rLfskcQdm@google.com>
Date:   Thu, 18 Aug 2022 04:08:11 +0000
From:   Tzung-Bi Shih <tzungbi@...nel.org>
To:     Tim Van Patten <timvp@...gle.com>
Cc:     rrangel@...omium.org, robbarnes@...gle.com,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] platform/chrome: cros_ec: Send host event for
 prepare/complete

On Tue, Aug 02, 2022 at 11:40:08AM -0600, Tim Van Patten wrote:
> Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM
> .prepare() and cros_ec_lpc_complete() during .complete(). This allows the
> EC to log entry/exit of AP's suspend/resume more accurately.

As what I commented on [1], the term "host event" in the commit title is
confusing.  Also, as this is a cros_ec_lpc specific patch, please change
the prefix.

[1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid/#24934911

> -static int cros_ec_lpc_resume(struct device *dev)
> +static void cros_ec_lpc_complete(struct device *dev)
>  {
>  	struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = cros_ec_resume(ec_dev);
>  
> -	return cros_ec_resume(ec_dev);
> +	dev_info(dev, "EC resume completed: ret = %d\n", ret);

cros_ec_resume() always returns 0.