linux-kernel - Re: [PATCH v3] AMD_SFH: Add a DMI quirk entry for Chromebooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 10:29:45 +0530
From:   Basavaraj Natikar <bnatikar@....com>
To:     Akihiko Odaki <akihiko.odaki@...il.com>
Cc:     Basavaraj Natikar <basavaraj.natikar@....com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v3] AMD_SFH: Add a DMI quirk entry for Chromebooks

On 8/16/2022 3:51 PM, Akihiko Odaki wrote:
> Google Chromebooks use Chrome OS Embedded Controller Sensor Hub instead
> of Sensor Hub Fusion and leaves MP2 uninitialized, which disables all
> functionalities, even including the registers necessary for feature
> detections.
>
> The behavior was observed with Lenovo ThinkPad C13 Yoga.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@...il.com>
> Suggested-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> index 4b90c86ee5f8..47774b9ab3de 100644
> --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> @@ -288,11 +288,29 @@ int amd_sfh_irq_init(struct amd_mp2_dev *privdata)
>  	return 0;
>  }
>  
> +static const struct dmi_system_id dmi_nodevs[] = {
> +	{
> +		/*
> +		 * Google Chromebooks use Chrome OS Embedded Controller Sensor
> +		 * Hub instead of Sensor Hub Fusion and leaves MP2
> +		 * uninitialized, which disables all functionalities, even
> +		 * including the registers necessary for feature detections.
> +		 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Google"),
> +		},
> +	},
> +	{ }
> +};
> +
>  static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  {
>  	struct amd_mp2_dev *privdata;
>  	int rc;
>  
> +	if (dmi_first_match(dmi_nodevs))
> +		return -ENODEV;
> +
>  	privdata = devm_kzalloc(&pdev->dev, sizeof(*privdata), GFP_KERNEL);
>  	if (!privdata)
>  		return -ENOMEM;

Could you please prefix amd_sfh patches with 'HID: amd_sfh:'
With that addressed,

Acked-by: Basavaraj Natikar <Basavaraj.Natikar@....com>

Thanks,
--
Basavaraj