linux-kernel - Re: [PATCH] MAINTAINERS: add PCI Endpoint NTB drivers to NTB files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818060230.GA12008@thinkpad>
Date:   Thu, 18 Aug 2022 11:32:30 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Jon Mason <jdmason@...zu.us>
Cc:     ntb@...ts.linux.dev, Bjorn Helgaas <helgaas@...nel.org>,
        Frank.Li@....com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kishon@...com
Subject: Re: [PATCH] MAINTAINERS: add PCI Endpoint NTB drivers to NTB files

+ Kishon (PCI EP Maintainer)

On Fri, Aug 12, 2022 at 03:42:05PM -0400, Jon Mason wrote:
> The PCI Endpoint NTB drivers are under the NTB umbrella.  Add an entry
> there to allow for notification of changes for it.
> 
> Signed-off-by: Jon Mason <jdmason@...zu.us>

Hi Jason,

I know that this patch is already in Linus's tree but I think this PCI Endpoint
VNTB driver is not going in a correct path. First, Kishon is not convinced with
the way the PCI Endpoint VNTB function driver is written currently. He prefers
the VirtIO approach over the current one [1].

But while the conversation was still going on, the series got merged via NTB
tree without any ACKs from the PCI/PCI_EP maintainers. Also, note that there
was a patch touching the PCI Controller driver as well and that was also not
ACKed [2].

If this trend is going to continue in the coming days, then I'm afraid that NTB
might end up being a backdoor for PCI/PCI_EP patches :(

Thanks,
Mani

[1] https://lore.kernel.org/all/20220222162355.32369-4-Frank.Li@nxp.com
[2] https://lore.kernel.org/all/20220222162355.32369-2-Frank.Li@nxp.com

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 64379c699903..47e9f86bd712 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14254,6 +14254,7 @@ W:	https://github.com/jonmason/ntb/wiki
>  T:	git git://github.com/jonmason/ntb.git
>  F:	drivers/net/ntb_netdev.c
>  F:	drivers/ntb/
> +F:	drivers/pci/endpoint/functions/pci-epf-*ntb.c
>  F:	include/linux/ntb.h
>  F:	include/linux/ntb_transport.h
>  F:	tools/testing/selftests/ntb/
> -- 
> 2.30.2
> 

-- 
மணிவண்ணன் சதாசிவம்