linux-kernel - Re: [PATCH v2 1/4] hw/riscv: virt: fix uart node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3026d87d-08a0-18d6-4b03-f0a05536d682@microchip.com>
Date:   Thu, 18 Aug 2022 06:29:10 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <palmer@...belt.com>, <qemu-riscv@...gnu.org>,
        <alistair.francis@....com>, <bin.meng@...driver.com>
CC:     <robh+dt@...nel.org>, <mail@...chuod.ie>,
        <daniel.lezcano@...aro.org>, <maz@...nel.org>,
        <tglx@...utronix.de>, <anup@...infault.org>,
        <aou@...s.berkeley.edu>, <guoren@...nel.org>,
        <sagar.kadam@...ive.com>, <jrtc27@...c27.com>,
        <ajones@...tanamicro.com>, <paul.walmsley@...ive.com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <robh@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH v2 1/4] hw/riscv: virt: fix uart node name

On 17/08/2022 21:05, Conor Dooley wrote:

I didn't realise this one slipped out too when I messed up mailing
unrelated patches yesterday, this is identical to what I previously
submitted as a v2 - I ran send-email on a dirty directory...

I can re-submit this as v3 if it makes things easier?

Thanks,
Conor.

> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> "uart" is not a node name that complies with the dt-schema.
> Change the node name to "serial" to ix warnings seen during
> dt-validate on a dtbdump of the virt machine such as:
> /stuff/qemu/qemu.dtb: uart@...00000: $nodename:0: 'uart@...00000' does not match '^serial(@.*)?$'
>          From schema: /stuff/linux/Documentation/devicetree/bindings/serial/8250.yaml
> 
> Reported-by: Rob Herring <robh@...nel.org>
> Link: https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/
> Fixes: 04331d0b56 ("RISC-V VirtIO Machine")
> Reviewed-by: Alistair Francis <alistair.francis@....com>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>   hw/riscv/virt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index bc424dd2f5..6c61a406c4 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -917,7 +917,7 @@ static void create_fdt_uart(RISCVVirtState *s, const MemMapEntry *memmap,
>       char *name;
>       MachineState *mc = MACHINE(s);
> 
> -    name = g_strdup_printf("/soc/uart@%lx", (long)memmap[VIRT_UART0].base);
> +    name = g_strdup_printf("/soc/serial@%lx", (long)memmap[VIRT_UART0].base);
>       qemu_fdt_add_subnode(mc->fdt, name);
>       qemu_fdt_setprop_string(mc->fdt, name, "compatible", "ns16550a");
>       qemu_fdt_setprop_cells(mc->fdt, name, "reg",
> --
> 2.37.1
>