lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Aug 2022 10:10:25 +0300 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Akhil P Oommen <quic_akhilpo@...cinc.com>, freedreno <freedreno@...ts.freedesktop.org>, dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org, Rob Clark <robdclark@...il.com>, Bjorn Andersson <bjorn.andersson@...aro.org>, Stephen Boyd <swboyd@...omium.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org> Cc: Douglas Anderson <dianders@...omium.org>, Andy Gross <agross@...nel.org>, Konrad Dybcio <konrad.dybcio@...ainline.org>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 2/5] clk: qcom: Allow custom reset ops On 17/08/2022 17:57, Akhil P Oommen wrote: Thank you for your patch. There is something to discuss/improve. > > return regmap_update_bits(rst->regmap, map->reg, mask, 0); > diff --git a/drivers/clk/qcom/reset.h b/drivers/clk/qcom/reset.h > index 2a08b5e..d4213b4 100644 > --- a/drivers/clk/qcom/reset.h > +++ b/drivers/clk/qcom/reset.h > @@ -8,9 +8,17 @@ > > #include <linux/reset-controller.h> > > +struct qcom_reset_ops { > + int (*reset)(void *priv); > + int (*assert)(void *priv); > + int (*deassert)(void *priv); > +}; > + > struct qcom_reset_map { > unsigned int reg; > u8 bit; > + struct qcom_reset_ops *ops; This should be pointer to const. Best regards, Krzysztof
Powered by blists - more mailing lists