linux-kernel - Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afcaffc6-aa07-d95f-6823-a858b53ee978@linux.intel.com>
Date:   Thu, 18 Aug 2022 11:14:41 +0300
From:   Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        sound-open-firmware@...a-project.org
Cc:     rander.wang@...el.com, pierre-louis.bossart@...ux.intel.com,
        ranjani.sridharan@...ux.intel.com, broonie@...nel.org
Subject: Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof
 in sof_ipc4_widget_setup_comp_src()



On 18/08/2022 11:17, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().

Good find, thank you.

Acked-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>

> Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  sound/soc/sof/ipc4-topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index af072b484a60..c6abfaf5d532 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
>  		goto err;
>  
>  	ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
> -				    swidget->num_tuples, sizeof(src), 1);
> +				    swidget->num_tuples, sizeof(*src), 1);
>  	if (ret) {
>  		dev_err(scomp->dev, "Parsing SRC tokens failed\n");
>  		goto err;

-- 
Péter