linux-kernel - RE: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DBBPR08MB4538258B55E51ADD2E42C9E5F76D9@DBBPR08MB4538.eurprd08.prod.outlook.com>
Date:   Thu, 18 Aug 2022 01:24:33 +0000
From:   Justin He <Justin.He@....com>
To:     Borislav Petkov <bp@...en8.de>, "Kani, Toshi" <toshi.kani@....com>
CC:     Ard Biesheuvel <ardb@...nel.org>, Len Brown <lenb@...nel.org>,
        James Morse <James.Morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        Robert Moore <robert.moore@...el.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        nd <nd@....com>, "stable@...nel.org" <stable@...nel.org>
Subject: RE: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the
 dependency on ghes



> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Thursday, August 18, 2022 5:35 AM
> To: Kani, Toshi <toshi.kani@....com>
> Cc: Justin He <Justin.He@....com>; Ard Biesheuvel <ardb@...nel.org>; Len
> Brown <lenb@...nel.org>; James Morse <James.Morse@....com>; Tony
> Luck <tony.luck@...el.com>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Robert Richter <rric@...nel.org>; Robert Moore
> <robert.moore@...el.com>; linux-acpi@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org; devel@...ica.org;
> Rafael J . Wysocki <rafael@...nel.org>; Shuai Xue
> <xueshuai@...ux.alibaba.com>; Jarkko Sakkinen <jarkko@...nel.org>;
> linux-efi@...r.kernel.org; nd <nd@....com>; stable@...nel.org
> Subject: Re: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove
> the dependency on ghes
> 
> On Wed, Aug 17, 2022 at 09:09:41PM +0000, Kani, Toshi wrote:
> > Since then, the change below enabled ghes_edac on Arm without this
> > known-good platforms check.
> >
> > commit eaa3a1d46 ("EDAC, ghes: Make platform-based whitelisting
> > x86-only")
> 
> Bah, I had forgotten about that one...
> 
> In any case, edac_mc_add_mc* is too late in the init path - that check should
> happen as the very first thing in the driver init function.
> 
> And looking at the ARM64 EDAC drivers, they're only a couple: thunderx,
> xgene, bluefield, dmc-520... And I'd still prefer if their maintainers explicitly
> ACK such a change to call ghes_get_devices() (for a lack of a better idea) and
> not enable ghes_edac on them blindly.
Okay, will include above changes in next version, thanks for the reminder.

--
Cheers,
Justin (Jia He)