linux-kernel - Re: [PATCH v3 0/4] ARM: Convert to ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13e8c9ba-c5ec-a231-5493-3255e1ef9db8@huawei.com>
Date:   Thu, 18 Aug 2022 17:15:36 +0800
From:   Li Huafei <lihuafei1@...wei.com>
To:     <linux@...linux.org.uk>
CC:     <mark.rutland@....com>, <peterz@...radead.org>, <mingo@...hat.com>,
        <acme@...nel.org>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...nel.org>, <namhyung@...nel.org>, <arnd@...db.de>,
        <rostedt@...dmis.org>, <nick.hawkins@....com>, <john@...ozen.org>,
        <mhiramat@...nel.org>, <ast@...nel.org>, <linyujun809@...wei.com>,
        <ndesaulniers@...gle.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-perf-users@...r.kernel.org>,
        <rmk+kernel@...linux.org.uk>, <ardb@...nel.org>, <will@...nel.org>,
        <broonie@...nel.org>, <linus.walleij@...aro.org>
Subject: Re: [PATCH v3 0/4] ARM: Convert to ARCH_STACKWALK



On 2022/7/27 12:00, Li Huafei wrote:
> This series mainly updates the ARM stack trace code to use the newer and
> simpler arch_stack_walk() interface (see patches 3 and 4). Two issues
> were fixed before that (see patches 1 and 2).
> 
> v3:
>  - According to the discussion with Linus and Russell in v1:
>    - Add a comment about "regs[1]" in patch 2, and remove the
>      unnecessary ternary operator in the initialization of
>      "frame->ex_frame".
>    - Remove the patch "ARM: stacktrace: Allow stack trace saving for
>      non-current tasks", and keep the check for not being able to
>      unwind non-current tasks (including tasks running on other CPUs)
>      when CONFIG_SMP=y in patch 4.
>  - Rebase to linux-5.19-rc8.
> 
> v2: https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/
>  - As suggested by Mark, the commit logs for patch 4 and 5 were
>    refined for easy review.
> 
> v1: https://lore.kernel.org/lkml/20220712021527.109921-1-lihuafei1@huawei.com/
> 
> Li Huafei (4):
>   ARM: stacktrace: Skip frame pointer boundary check for
>     call_with_stack()
>   ARM: stacktrace: Avoid duplicate saving of exception PC value
>   ARM: stacktrace: Make stack walk callback consistent with generic code
>   ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK
> 
>  arch/arm/Kconfig                  |   1 +
>  arch/arm/include/asm/stacktrace.h |   8 +-
>  arch/arm/kernel/perf_callchain.c  |   9 +-
>  arch/arm/kernel/return_address.c  |   9 +-
>  arch/arm/kernel/stacktrace.c      | 191 ++++++++++++++----------------
>  arch/arm/lib/call_with_stack.S    |   2 +
>  6 files changed, 110 insertions(+), 110 deletions(-)
> 


Hi Russell，

Do you have any more comments on this patch set? Can you add this patch
set to your patch tracker? Thanks!

Thanks,
Huafei