linux-kernel - [PATCH] cachefiles: fix error return code in cachefiles_ondemand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818094939.1548183-1-sunke32@huawei.com>
Date:   Thu, 18 Aug 2022 17:49:39 +0800
From:   Sun Ke <sunke32@...wei.com>
To:     <dhowells@...hat.com>
CC:     <linux-cachefs@...hat.com>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <jefflexu@...ux.alibaba.com>,
        <sunke32@...wei.com>
Subject: [PATCH] cachefiles: fix error return code in cachefiles_ondemand_copen()

If size < 0; open request will fail, but cachefiles_ondemand_copen return 0.
Fix to return a negative error code.

Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie")
Signed-off-by: Sun Ke <sunke32@...wei.com>
---
 fs/cachefiles/ondemand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
index 1fee702d5529..a31d3ff0ce5f 100644
--- a/fs/cachefiles/ondemand.c
+++ b/fs/cachefiles/ondemand.c
@@ -161,6 +161,7 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args)
 		if (!IS_ERR_VALUE(size))
 			size = -EINVAL;
 		req->error = size;
+		ret = -EINVAL;
 		goto out;
 	}
 
-- 
2.31.1