linux-kernel - Re: [PATCH v3 2/2] power: supply: rt9471: Add Richtek RT9471 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6f3d97e-547a-9797-1469-bbe5d80a3bb8@linaro.org>
Date:   Thu, 18 Aug 2022 13:18:32 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     ChiYuan Huang <u0084500@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        游子馨 <alina_yu@...htek.com>,
        cy_huang <cy_huang@...htek.com>, alinayu829@...il.com,
        Linux PM <linux-pm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] power: supply: rt9471: Add Richtek RT9471 charger
 driver

On 18/08/2022 13:16, ChiYuan Huang wrote:
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 於 2022年8月18日 週四 下午4:09寫道：
>>
>> On 18/08/2022 04:21, cy_huang wrote:
>>> From: ChiYuan Huang <cy_huang@...htek.com>
>>>
>>> Add support for the RT9471 3A 1-Cell Li+ battery charger.
>>>
>>> The RT9471 is a highly-integrated 3A switch mode battery charger with
>>> low impedance power path to better optimize the charging efficiency.
>>>
>>> Co-developed-by: Alina Yu <alina_yu@...htek.com>
>>> Signed-off-by: Alina Yu <alina_yu@...htek.com>
>>> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
>>> ---
>>> Since v2:
>>> - Fix checkpatch error about 'foo * bar' to 'foo *bar' in psy_device_to_chip function.
>>> - Specify the member name directly for the use of linear range.
>>>
>>> ---
>>
>> (...)
>>
>>> +
>>> +static DEVICE_ATTR_RW(sysoff_enable);
>>> +static DEVICE_ATTR_RW(charge_term_enable);
>>> +static DEVICE_ATTR_RW(port_detect_enable);
>>> +
>>> +static struct attribute *rt9471_sysfs_entries[] = {
>>> +     &dev_attr_sysoff_enable.attr,
>>> +     &dev_attr_charge_term_enable.attr,
>>> +     &dev_attr_port_detect_enable.attr,
>>> +     NULL
>>
>> You need to document the sysfs ABI in Documentation.
> Can it be define in 'sysfs-class-power' or a dedicated file called
> 'sysfs-class-power-rt9471'?
> Not sure which one is better.

I don't know what is Sebastian's preference. You can wait for his input
or do similarly as last patches reviewed/picked up by him.

Best regards,
Krzysztof