linux-kernel - Re: [PATCH v1] regmap: introduce value tracing for regmap bulk operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818121515.6azkxyqetnunwsc6@CAB-WSD-L081021.sigma.sbrf.ru>
Date:   Thu, 18 Aug 2022 12:15:00 +0000
From:   Dmitry Rokosov <DDRokosov@...rdevices.ru>
To:     "broonie@...nel.org" <broonie@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "linux@...musvillemoes.dk>" <linux@...musvillemoes.dk>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "maz@...nel.org>" <maz@...nel.org>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>
CC:     kernel <kernel@...rdevices.ru>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] regmap: introduce value tracing for regmap bulk
 operations

+Thomas, Rasmus and Marc

On Tue, Aug 16, 2022 at 06:14:48PM +0000, Dmitry Rokosov wrote:
> Currently, only one-register io operations support tracepoints with
> value logging. For the regmap bulk operations developer can view
> hw_start/hw_done tracepoints with starting reg number and registers
> count to be reading or writing. This patch injects tracepoints with
> dumping registers values in the hex format to regmap bulk reading
> and writing.
> 
> Signed-off-by: Dmitry Rokosov <ddrokosov@...rdevices.ru>
> ---
>  drivers/base/regmap/regmap.c |  7 ++++++
>  drivers/base/regmap/trace.h  | 43 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 50 insertions(+)
> 
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index c3517ccc3159..673ad37df11f 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -2323,6 +2323,10 @@ int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val,
>  
>  		kfree(wval);
>  	}
> +
> +	if (!ret)
> +		trace_regmap_bulk_write(map, reg, val, val_bytes * val_count);
> +
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(regmap_bulk_write);
> @@ -3068,6 +3072,9 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
>  		map->unlock(map->lock_arg);
>  	}
>  
> +	if (!ret)
> +		trace_regmap_bulk_read(map, reg, val, val_bytes * val_count);
> +
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(regmap_bulk_read);
> diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h
> index 9abee14df9ee..04329ba68ec5 100644
> --- a/drivers/base/regmap/trace.h
> +++ b/drivers/base/regmap/trace.h
> @@ -64,6 +64,49 @@ DEFINE_EVENT(regmap_reg, regmap_reg_read_cache,
>  
>  );
>  
> +DECLARE_EVENT_CLASS(regmap_bulk,
> +
> +	TP_PROTO(struct regmap *map, unsigned int reg,
> +		 const void *val, int val_len),
> +
> +	TP_ARGS(map, reg, val, val_len),
> +
> +	TP_STRUCT__entry(
> +		__string(name, regmap_name(map))
> +		__field(unsigned int, reg)
> +		__dynamic_array(char, buf, val_len)
> +		__field(int, val_len)
> +	),
> +
> +	TP_fast_assign(
> +		__assign_str(name, regmap_name(map));
> +		__entry->reg = reg;
> +		__entry->val_len = val_len;
> +		if (val)
> +			memcpy(__get_dynamic_array(buf), val, val_len);
> +	),
> +
> +	TP_printk("%s reg=%x val=%s", __get_str(name),
> +		  (unsigned int)__entry->reg,
> +		  __print_hex(__get_dynamic_array(buf), __entry->val_len))
> +);
> +
> +DEFINE_EVENT(regmap_bulk, regmap_bulk_write,
> +
> +	TP_PROTO(struct regmap *map, unsigned int reg,
> +		 const void *val, int val_len),
> +
> +	TP_ARGS(map, reg, val, val_len)
> +);
> +
> +DEFINE_EVENT(regmap_bulk, regmap_bulk_read,
> +
> +	TP_PROTO(struct regmap *map, unsigned int reg,
> +		 const void *val, int val_len),
> +
> +	TP_ARGS(map, reg, val, val_len)
> +);
> +
>  DECLARE_EVENT_CLASS(regmap_block,
>  
>  	TP_PROTO(struct regmap *map, unsigned int reg, int count),
> -- 
> 2.36.0

-- 
Thank you,
Dmitry