linux-kernel - Re: [PATCH 11/11] musb: fix USB_MUSB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2nfKPQncn7sp1K4J+sU+uYuyb-7FOCh5jAmtigJ8Mk1Q@mail.gmail.com>
Date:   Thu, 18 Aug 2022 16:27:17 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-arm-kernel@...ts.infradead.org, Bin Liu <b-liu@...com>,
        Arnd Bergmann <arnd@...db.de>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Felipe Balbi <balbi@...com>, Tony Lindgren <tony@...mide.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Conor Dooley <conor.dooley@...rochip.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] musb: fix USB_MUSB_TUSB6010 dependency

On Thu, Aug 18, 2022 at 4:08 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Thu, Aug 18, 2022 at 03:57:20PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > Turning on NOP_USB_XCEIV as builtin broke the TUSB6010 driver because
> > of an older issue with the depencency.
> >
> > It is not necessary to forbid NOP_USB_XCEIV=y in combination with
> > USB_MUSB_HDRC=m, but only the reverse, which causes the link failure
> > from the original Kconfig change.
> >
> > Use the correct dependency to still allow NOP_USB_XCEIV=n or
> > NOP_USB_XCEIV=y but forbid NOP_USB_XCEIV=m when USB_MUSB_HDRC=m
> > to fix the multi_v7_defconfig for tusb.
> >
> > Fixes: ab37a7a890c1 ("ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in")
> > Fixes: c0442479652b ("usb: musb: Fix randconfig build issues for Kconfig options")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >  drivers/usb/musb/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Want me to take this through my tree now?

Yes, please do.

Thanks,

       Arnd