linux-kernel - Re: [PATCH v3 2/2] USB: trancevibrator: simplify tv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD-N9QUO9i0rkUGu_buBLSkFaTvvHp69ynkP30kEcmCRDDQg8A@mail.gmail.com>
Date:   Thu, 18 Aug 2022 23:15:22 +0800
From:   Dongliang Mu <mudongliangabcd@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Dongliang Mu <dzm91@...t.edu.cn>, USB <linux-usb@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] USB: trancevibrator: simplify tv_probe

On Thu, Aug 18, 2022 at 11:06 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Fri, Aug 12, 2022 at 02:18:02PM +0800, Dongliang Mu wrote:
> > From: Dongliang Mu <mudongliangabcd@...il.com>
> >
> > The function tv_probe does not need to invoke kfree when the
> > allocation fails. So let's simplify the code of tv_probe.
> >
> > Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> > ---
> > v2->v3: fix the truncated subject of PATCH 2/2.
> > v1->v2: no change
> >
> >  drivers/usb/misc/trancevibrator.c | 11 ++---------
> >  1 file changed, 2 insertions(+), 9 deletions(-)
>
> Note, I would recommend you work on basic "clean up" patches in the
> drivers/staging/ directory so as to get experience on how to submit
> patches properly before working in other parts of the kernel tree.  That
> way subsystems that don't normally take "cleanup" patches don't get
> bogged down in basic patch-process issues like this one did.

I see. Thanks for your suggestion.

>
> thanks,
>
> greg k-h